update concurrency group definition #28373
Conversation
|
R: @Abacn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
ah it's still in draft status (and looks good for me) |
|
@Abacn Yeah i left in in draft until confirmation. Its ready now. |
|
@Abacn @damccorm Seems like this is causing issues of perpetually queued jobs somehow. Could be connected to some Actions outage which would explain the first queued job getting stuck but all further are considered the same group somehow. Think the issue is the body of comment : and looking at the first job trigger we get to #28272 (comment) Should we perhaps use comment id or something https://docs.github.com/en/webhooks/webhook-events-and-payloads#issue_comment |
|
fair - let's use comment id |
Adds comment body to concurrency group definition to prevent different PRs canceling other jobs.
Fixes part of: #28320
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.